BFPOWER/physical
2
0
Fork 0
Code Issues 2 Pull Requests Releases Activity

Reexport everything in physical from physical-node and physical-commander #5

New Issue
Open
opened 2023-07-20 03:04:28 +00:00 by zack · 0 comments
zack commented 2023-07-20 03:04:28 +00:00
Owner
Copy Link

Currently some things (e.g. specific transducers like thermocouples and lm35) are not reexported from node and commander. This is a bit annoying for library users as it means a separate dependency on physical (as opposed to physical-node or physical-commander) is needed even when the project is just a node or just a commander. However, it's also a bit tedious to implement this because these things are feature gated so we'd need to mimic the module structure for reexporting and copy over all the features.

Currently some things (e.g. specific transducers like thermocouples and lm35) are not reexported from node and commander. This is a bit annoying for library users as it means a separate dependency on physical (as opposed to physical-node or physical-commander) is needed even when the project is just a node or just a commander. However, it's also a bit tedious to implement this because these things are feature gated so we'd need to mimic the module structure for reexporting and copy over all the features.
zack added the
enhancement
proposed
implementation
needs assignee
 labels 2023-07-20 03:04:28 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
build / deploy
packaging and deployment of repository contents
duplicate
This issue or pull request already exists
enhancement
accepted
Enhancement that has been accepted for inclusion in the project
enhancement
proposed
Enhancement proposal to be reviewed and discussed
enhancement
rejected
Enhancement proposal that has been reviewed and rejected
error
confirmed
Bug report that has been investigated and confirmed
error
invalid
Bug report that has been reviewed and found that reported behavior was expected or caused by a different issue
error
suspected
Bug report that needs confirmation it isn't intended behavior or result of misconfiguration or external factors
implementation
complete
Solution has been fully implemented and merged into master
implementation
in progress
Someone is currently implementing this issue
implementation
needs assignee
Implementation has either not been started yet or has been abandoned by the previous builder, need someone to take on this issue
implementation
pending dependency
The solution to this issue is dependent on something else being done
implementation
pending review
Solution implemented, needs further review or merger
meta
Issues about project management
question / discussion
More information is needed
No Label
enhancement
proposed
implementation
needs assignee
Milestone
No items
No Milestone
Assignees
Clear assignees
shan zack
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: BFPOWER/physical#5
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?