BFPOWER/physical
2
0
Fork 0
Code Issues 2 Pull Requests Releases Activity

The comms::Receiver implementation for stm32::usb only works if the largest message ever sent is smaller than a single USB packet. #13

New Issue
Closed
opened 2024-07-02 22:15:43 +00:00 by zack · 1 comment
zack commented 2024-07-02 22:15:43 +00:00
Owner
Copy Link
Copy Source

I don't think there is a zero overhead way around this and messages being smaller than a single USB packet is by far the most common case for physical nodes so we don't want to take the overhead of split messages here. The best solution may just be to make this as clear as possible and make another implementation for messages split over multiple packets.

I don't think there is a zero overhead way around this and messages being smaller than a single USB packet is by far the most common case for physical nodes so we don't want to take the overhead of split messages here. The best solution may just be to make this as clear as possible and make another implementation for messages split over multiple packets.
zack added the
error
confirmed
label 2024-07-02 22:15:43 +00:00
zack commented 2024-07-02 22:35:06 +00:00
Author
Owner
Copy Link
Copy Source

Addressed with feature flag in 403df6f5f4

Addressed with feature flag in 403df6f5f42c8a66e0a35aa24a0bcd533e86f261
zack closed this issue 2024-07-02 22:35:27 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
build / deploy
packaging and deployment of repository contents
duplicate
This issue or pull request already exists
 meta
Issues about project management
 question / discussion
More information is needed
enhancement
accepted
Enhancement that has been accepted for inclusion in the project
enhancement
proposed
Enhancement proposal to be reviewed and discussed
enhancement
rejected
Enhancement proposal that has been reviewed and rejected
error
confirmed
Bug report that has been investigated and confirmed
error
invalid
Bug report that has been reviewed and found that reported behavior was expected or caused by a different issue
error
suspected
Bug report that needs confirmation it isn't intended behavior or result of misconfiguration or external factors
implementation
complete
Solution has been fully implemented and merged into master
implementation
in progress
Someone is currently implementing this issue
implementation
needs assignee
Implementation has either not been started yet or has been abandoned by the previous builder, need someone to take on this issue
implementation
pending dependency
The solution to this issue is dependent on something else being done
implementation
pending review
Solution implemented, needs further review or merger
No labels
error
confirmed
Milestone
No items
No Milestone
Assignees
Clear assignees
shan (Shannon Levy) zack (Zachary Levy)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: BFPOWER/physical#13