BFPOWER/physical
2
0
Fork 0
Code Issues 2 Pull Requests Releases Activity

Make lm35 convert function use i32 for uom base type for voltage and temperature #10

New Issue
Closed
opened 2024-02-19 00:20:24 +00:00 by zack · 1 comment
zack commented 2024-02-19 00:20:24 +00:00
Owner
Copy Link

Integer operations may be faster on some devices. All possible values and all arithmetic needed for the conversion can fit in and be done with an i32. The cast to a f32 should always be a single fast instruction. Should we:

  1. Switch the convert function to use i32.
  2. Add an i32 version of the convert function in addition to the f32 version.
  3. Make the uom base type generic for the convert function.
  4. Leave it as it is.
Integer operations may be faster on some devices. All possible values and all arithmetic needed for the conversion can fit in and be done with an `i32`. The cast to a `f32` should always be a single fast instruction. Should we: 1. Switch the convert function to use `i32`. 1. Add an `i32` version of the convert function in addition to the f32 version. 1. Make the uom base type generic for the convert function. 1. Leave it as it is.
zack added the
enhancement
proposed
implementation
needs assignee
 labels 2024-02-19 00:20:24 +00:00
zack commented 2024-02-23 17:18:18 +00:00
Author
Owner
Copy Link

It's problem is to scale we need to convert the voltage to a certain unit. To not use a decimal and get full accuracy that unit would need to be millivolts but if we use millivolts instead of volts we would need to divide instead of multiply and integer division would presumably be much slower than even float multiplication so we will leave it as f32.

It's problem is to scale we need to convert the voltage to a certain unit. To not use a decimal and get full accuracy that unit would need to be millivolts but if we use millivolts instead of volts we would need to divide instead of multiply and integer division would presumably be much slower than even float multiplication so we will leave it as f32.
zack closed this issue 2024-02-23 17:18:18 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
build / deploy
packaging and deployment of repository contents
duplicate
This issue or pull request already exists
enhancement
accepted
Enhancement that has been accepted for inclusion in the project
enhancement
proposed
Enhancement proposal to be reviewed and discussed
enhancement
rejected
Enhancement proposal that has been reviewed and rejected
error
confirmed
Bug report that has been investigated and confirmed
error
invalid
Bug report that has been reviewed and found that reported behavior was expected or caused by a different issue
error
suspected
Bug report that needs confirmation it isn't intended behavior or result of misconfiguration or external factors
implementation
complete
Solution has been fully implemented and merged into master
implementation
in progress
Someone is currently implementing this issue
implementation
needs assignee
Implementation has either not been started yet or has been abandoned by the previous builder, need someone to take on this issue
implementation
pending dependency
The solution to this issue is dependent on something else being done
implementation
pending review
Solution implemented, needs further review or merger
meta
Issues about project management
question / discussion
More information is needed
No Label
enhancement
proposed
implementation
needs assignee
Milestone
No items
No Milestone
Assignees
Clear assignees
shan zack
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: BFPOWER/physical#10
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?